Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use U256::is_zero #5616

Merged
merged 1 commit into from
Nov 28, 2023
Merged

chore: use U256::is_zero #5616

merged 1 commit into from
Nov 28, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 28, 2023

Closes #5147

replace == U256::ZERO checks with is_zero

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Nov 28, 2023
Rjected
Rjected approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit 18d563d Nov 28, 2023
27 checks passed
@mattsse mattsse deleted the matt/use-is-zero branch November 28, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use built-in ruint is_zero() function to replace == U256::ZERO
2 participants
@mattsse @Rjected