Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use direct conversion for payload fee metrics #5564

Merged
merged 2 commits into from
Nov 25, 2023
Merged

fix: use direct conversion for payload fee metrics #5564

merged 2 commits into from
Nov 25, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Nov 25, 2023

uses f64::from instead of .to::<u128>, to do a lossy conversion instead of panicking

@Rjected Rjected added C-debt Refactor of code section that is hard to understand or maintain A-block-building Related to block building labels Nov 25, 2023
@mattsse mattsse added this pull request to the merge queue Nov 25, 2023
Merged via the queue into main with commit 5f38a5f Nov 25, 2023
27 checks passed
@mattsse mattsse deleted the dan/remove-to-in-fee-metrics branch November 25, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-block-building Related to block building C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse