Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): make c-kzg actually a feature of reth-primitives #5525

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 22, 2023

c-kzg was still pulled in via default features of revm and revm-primitives

set ws default-features of those to false and opt in via primitives feature, enabled by default

reth-primitives = { path = "../reth/crates/primitives", default-features = false }

before:

cargo tree -p c-kzg -i                                                                    ? master 
c-kzg v0.4.0
├── revm-precompile v2.2.0 (https://github.com/bluealloy/revm?branch=reth_freeze#74643d37)
│   └── revm v3.5.0 (https://github.com/bluealloy/revm?branch=reth_freeze#74643d37)
│       └── reth-primitives v0.1.0-alpha.11 (https://github.com/paradigmxyz/reth#e5b33dbe)
│           └── reth-tmp v0.1.0 (/Users/Matthias/git/rust/reth-tmp)
└── revm-primitives v1.3.0 (https://github.com/bluealloy/revm?branch=reth_freeze#74643d37)
    ├── reth-codecs v0.1.0-alpha.11 (https://github.com/paradigmxyz/reth#e5b33dbe)
    │   └── reth-primitives v0.1.0-alpha.11 (https://github.com/paradigmxyz/reth#e5b33dbe) (*)
    ├── reth-primitives v0.1.0-alpha.11 (https://github.com/paradigmxyz/reth#e5b33dbe) (*)
    ├── revm-interpreter v1.3.0 (https://github.com/bluealloy/revm?branch=reth_freeze#74643d37)
    │   └── revm v3.5.0 (https://github.com/bluealloy/revm?branch=reth_freeze#74643d37) (*)
    └── revm-precompile v2.2.0 (https://github.com/bluealloy/revm?branch=reth_freeze#74643d37) (*)

now

cargo tree -p c-kzg -i                                                                    ? master 
warning: nothing to print.

@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Nov 22, 2023
@mattsse mattsse force-pushed the matt/truly-make-c-kzg-optional branch from 95495d6 to 226eb86 Compare November 22, 2023 00:24
@gakonst gakonst added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 857ceeb Nov 22, 2023
27 checks passed
@gakonst gakonst deleted the matt/truly-make-c-kzg-optional branch November 22, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants