Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(op-reth): clear accesslist for Deposit txs #5513

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix(op-reth): clear accesslist for Deposit txs #5513

merged 1 commit into from
Nov 21, 2023

Conversation

datskos
Copy link
Contributor

@datskos datskos commented Nov 21, 2023

op-reth cannot sync past block 3106894 on base mainnet.

This is because fill_tx_env does not clear the access list for Transaction::Deposit. So if the last transaction in the previous block used an access list, the next block (such as 3106894) will fail to execute due to BlockGasUsed mismatch error. This PR should fix that

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-execution Related to the Execution and EVM labels Nov 21, 2023
@rkrasiuk rkrasiuk added the A-op-reth Related to Optimism and op-reth label Nov 21, 2023
@rkrasiuk rkrasiuk added this pull request to the merge queue Nov 21, 2023
Merged via the queue into paradigmxyz:main with commit 3e0caae Nov 21, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-execution Related to the Execution and EVM A-op-reth Related to Optimism and op-reth C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datskos @rkrasiuk