chore(tree): minor Chain modifications
#5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-debt
mattsse
approved these changes
Nov 18, 2023
rkrasiuk
commented
Nov 18, 2023
Comment on lines
-950
to
+959
| let mut block_fork_number = canonical.fork_block_number(); | ||
| let mut fork_block = canonical.fork_block(); | ||
| let mut chains_to_promote = vec![canonical]; | ||
|
|
||
| // loop while fork blocks are found in Tree. | ||
| while let Some(chain_id) = self.block_indices().get_blocks_chain_id(&block_fork.hash) { | ||
| let chain = self.state.chains.remove(&chain_id).expect("To fork to be present"); | ||
| block_fork = chain.fork_block(); | ||
| while let Some(chain_id) = self.block_indices().get_blocks_chain_id(&fork_block.hash) { | ||
| let chain = self.state.chains.remove(&chain_id).expect("fork is present"); | ||
| // canonical chain is lower part of the chain. | ||
| let canonical = | ||
| self.split_chain(chain_id, chain, ChainSplitTarget::Number(block_fork_number)); | ||
| block_fork_number = canonical.fork_block_number(); | ||
| self.split_chain(chain_id, chain, ChainSplitTarget::Number(fork_block.number)); | ||
| fork_block = canonical.fork_block(); |
There was a problem hiding this comment.
this change preserves old behavior because chain.fork_block() equals to canonical.fork_block() as canonical is just a lower part of the chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chain's fields