Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make Cursor iterators depend on the cursor's lifetime #5479

Merged
merged 1 commit into from
Nov 17, 2023
Merged

chore: make Cursor iterators depend on the cursor's lifetime #5479

merged 1 commit into from
Nov 17, 2023

Conversation

DaniPopes
Copy link
Member

Follow up to #5476

mattsse
mattsse approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, that's better
lgtm

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Nov 17, 2023
@DaniPopes DaniPopes added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit 7162228 Nov 17, 2023
25 checks passed
@DaniPopes DaniPopes deleted the dani/cursor-safety branch November 17, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse