feat: refactor generation of snapshots from the cli #5464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joshieDo
commented
Nov 16, 2023
joshieDo
commented
- Refactors the generation of snapshots from the cli (dedup some code)
- Add parallelism if desired
- Add some stats that get printed at the end of the generation
joshieDo
added
A-cli
mattsse
approved these changes
Nov 16, 2023
shekhirin
approved these changes
Nov 17, 2023
| /// statistics about various aspects of each snapshot, such as filters size, | ||
| /// offset index size, offset list size, and loading time. | ||
| fn stats(&self, snapshots: Vec<impl AsRef<Path>>) -> eyre::Result<()> { | ||
| let mb = 1024.0 * 1024.0; |
Comment on lines
+243
to
+244
| avg_duration.as_millis() as f64, | ||
| avg_duration.as_micros() as f64 |
There was a problem hiding this comment.
can we just use the Debug impl for Duration here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.