Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular canonicalization metrics dashboard update #5454

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

solidoracle
Copy link
Contributor

@solidoracle solidoracle commented Nov 16, 2023

fixes #5337
Screenshot 2023-11-21 at 19 50 51
Screenshot 2023-11-21 at 19 44 57

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start, I don't think the values on the left are actually ms, since it's a histogram graph I'm pretty sure they're percentiles. Instead of using the histogram graph, could we have a line graph that shows 50/90/95/99/99.9 percentiles? I find them easier to understand than the heatmaps, but open to other opinions

@rkrasiuk rkrasiuk added the A-observability Related to tracing, metrics, logs and other observability tools label Nov 17, 2023
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, and works locally, thanks!

@Rjected Rjected added this pull request to the merge queue Dec 1, 2023
Merged via the queue into paradigmxyz:main with commit 346f135 Dec 1, 2023
27 checks passed
@shekhirin
Copy link
Collaborator

shekhirin commented Dec 1, 2023

@solidoracle hey, sorry I didn't notice this PR, so it will be a delayed review. Let me know if you have time and want to finish the dashboard, otherwise no worries, we will fix the remaining issues 🙂


image

  1. I believe the unit is incorrect, the value should be around 400ms. The metrics are reported in seconds.
  2. We should filter the query by selected instance, see other charts. Otherwise, with multiple instances, you get all of them on the charts.
  3. Can we unify reth_blockchain_tree_make_canonical_duration into one chart with action selector and reth_storage_providers_database_duration into the other with the similar selector, so we don't have a very long dashboard? That way, we'll still be able to see all actions separately, but the charts will take less space.

@solidoracle
Copy link
Contributor Author

solidoracle commented Dec 1, 2023

hey @shekhirin, will fix in follow-up PR👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Granular canonicalization metrics dashboard
4 participants