-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granular canonicalization metrics dashboard update #5454
Granular canonicalization metrics dashboard update #5454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great start, I don't think the values on the left are actually ms, since it's a histogram graph I'm pretty sure they're percentiles. Instead of using the histogram graph, could we have a line graph that shows 50/90/95/99/99.9 percentiles? I find them easier to understand than the heatmaps, but open to other opinions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, and works locally, thanks!
@solidoracle hey, sorry I didn't notice this PR, so it will be a delayed review. Let me know if you have time and want to finish the dashboard, otherwise no worries, we will fix the remaining issues 🙂
|
hey @shekhirin, will fix in follow-up PR👍🏻 |
fixes #5337