Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net): check bounds on message logging #5448

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

shekhirin
Copy link
Collaborator

Caught in runtime

thread 'tokio-runtime-worker' panicked at 'range end index 10 out of range for slice of length 5', /home/ubuntu/reth/crates/net/eth-wire/src/ethstream.rs:247:53

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-networking Related to networking in general labels Nov 15, 2023
@shekhirin shekhirin marked this pull request as ready for review November 15, 2023 18:28
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, nice find, 50 is a reasonable cutoff

@mattsse mattsse added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 49f4606 Nov 15, 2023
25 checks passed
@mattsse mattsse deleted the alexey/eth-wire-log branch November 15, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants