feat: phase out environment trait #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
rkrasiuk,
Rjected,
rakita,
joshieDo and
onbjerg
as code owners
mattsse
force-pushed
the
matt/phase-out-env-kind-trait
branch
from
d6d77f8
to
e9ee6d0
Compare
mattsse
added
the
C-debt
mattsse
force-pushed
the
matt/phase-out-env-kind-trait
branch
from
e9ee6d0
to
4ad93c9
Compare
DaniPopes
approved these changes
Nov 15, 2023
|
pretty sure we can do that as well, if there are typelevel checks we can just use runtime checks instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the environment kind was super cumbersome to work with, it's only used when the environment is openened.
It also only controls the WriteMap setting (see new docs) and not the mode, which is a separate setting, but only takes affect if the DB is opened in RW mode.
naming can be discussed, and we can do a few more cleanups following this PR