Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use reth_primitives instead of revm_primitives #5434

Merged
merged 1 commit into from
Nov 15, 2023
Merged

use reth_primitives instead of revm_primitives #5434

merged 1 commit into from
Nov 15, 2023

Conversation

supernovahs
Copy link
Contributor

Ref #4737

Also, wanted to know what else needs to be done in 4737.

mattsse
mattsse approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks reasonable, no need to pull in revm_primitives, yes

@mattsse mattsse added this pull request to the merge queue Nov 15, 2023
Merged via the queue into paradigmxyz:main with commit 3527213 Nov 15, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supernovahs @mattsse