Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:Support BlockHashOrNumber with block_with_senders #5356

Merged
merged 4 commits into from
Nov 9, 2023
Merged

feat:Support BlockHashOrNumber with block_with_senders #5356

merged 4 commits into from
Nov 9, 2023

Conversation

supernovahs
Copy link
Contributor

Ref #5302

@supernovahs
Copy link
Contributor Author

Looks like my nightly fmt is doing some weird formatting 😅

mattsse
mattsse requested changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah please use nightly formatting and undo ;

crates/storage/provider/src/providers/database/provider.rs Outdated Show resolved Hide resolved
crates/storage/provider/src/providers/database/provider.rs Outdated Show resolved Hide resolved
crates/storage/provider/src/providers/database/provider.rs Outdated Show resolved Hide resolved
shekhirin
shekhirin previously requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small changes, then LGTM

crates/storage/provider/src/providers/database/provider.rs Outdated Show resolved Hide resolved
crates/storage/provider/src/providers/database/provider.rs Outdated Show resolved Hide resolved
mattsse
mattsse requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol style nits

crates/stages/src/stages/execution.rs Outdated Show resolved Hide resolved
crates/storage/provider/src/providers/database/provider.rs Outdated Show resolved Hide resolved
mattsse
mattsse approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@mattsse mattsse added this pull request to the merge queue Nov 9, 2023
Merged via the queue into paradigmxyz:main with commit 475c42e Nov 9, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@shekhirin shekhirin shekhirin left review comments

@Rjected Rjected Awaiting requested review from Rjected

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@supernovahs @shekhirin @mattsse