Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(meta): manifest maintenance #5353

Merged
merged 6 commits into from
Nov 8, 2023
Merged

chore(meta): manifest maintenance #5353

merged 6 commits into from
Nov 8, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 8, 2023

Somewhat related string of commands to clean up Cargo manifests. See each commit's description for how it was done.

```
description = """\n(.*)\n"""
description = "$1"
```
```bash
set -eo pipefail
names=$(cargo metadata --format-version 1 | jq -r '.packages.[].name | select(startswith("reth"))')
manifests=$(fd Cargo.toml)
for name in $names; do
    found=$(rg "name = \"$name\"" $manifests | head -n1)
    echo "$name = { path = \"$(dirname "$found")\" }"
done
```
```
(reth-.*) = \{ path = ".*?"(, .*?)? \}
$1 = { workspace = true$2 }
```
```
 = { workspace = true }
.workspace = true
```
@DaniPopes DaniPopes added the A-meta Changes in the contributor workflow and planning label Nov 8, 2023
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

are you using dlint for formatting?

@mattsse mattsse added this pull request to the merge queue Nov 8, 2023
@DaniPopes
Copy link
Member Author

Merged via the queue into main with commit e897764 Nov 8, 2023
25 checks passed
@mattsse mattsse deleted the dani/manifest-maintenance branch November 8, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Changes in the contributor workflow and planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants