fix: prevent decoding U256 TxValue on mainnet #5344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
TxValue
s larger thanU256
from being decoded when theoptimism
feature is not enabled. This means there is no chance of the node decoding a transaction with aTxValue
larger thanU256
, and attempting to commit that value in the DB, which would panic from theto
conversion:reth/crates/primitives/src/transaction/tx_value.rs
Lines 73 to 76 in db11909