Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: timestamp fork activation semantics #4785

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

rkrasiuk
Copy link
Member

Description

Snob PR regarding timestamp fork activation semantics.

is_activated means fork activation at a given timestamp (one-time action).
is_active conveys the meaning of fork "activeness" at a given timestamp (continuous property of the fork).

@rkrasiuk rkrasiuk added the C-debt Refactor of code section that is hard to understand or maintain label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #4785 (f6d6368) into main (6d634e9) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 58.82%.

Impacted file tree graph

Files Coverage Δ
crates/consensus/common/src/validation.rs 73.46% <100.00%> (ø)
crates/primitives/src/chain/spec.rs 98.08% <100.00%> (ø)
crates/revm/src/state_change.rs 73.00% <100.00%> (ø)
crates/rpc/rpc-engine-api/src/engine_api.rs 79.44% <100.00%> (ø)
...torage/provider/src/providers/database/provider.rs 78.90% <100.00%> (ø)
crates/revm/revm-primitives/src/config.rs 91.19% <0.00%> (ø)
crates/transaction-pool/src/validate/eth.rs 6.94% <33.33%> (ø)
crates/payload/basic/src/lib.rs 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.52% <11.76%> (+<0.01%) ⬆️
unit-tests 63.42% <58.82%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.23% <ø> (ø)
blockchain tree 83.69% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 73.49% <100.00%> (ø)
trie 94.52% <ø> (+0.03%) ⬆️
txpool 49.97% <33.33%> (ø)
networking 76.87% <ø> (+0.03%) ⬆️
rpc 57.67% <100.00%> (-0.02%) ⬇️
consensus 62.84% <100.00%> (ø)
revm 28.33% <50.00%> (ø)
payload builder 8.20% <0.00%> (ø)
primitives 86.52% <100.00%> (+0.02%) ⬆️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@rkrasiuk rkrasiuk added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit dae31fa Sep 26, 2023
23 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/timestamp-fork-activate-check-semantics branch September 26, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants