fix: add excess_blob_gas for first cancun block #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-bug
Codecov Report
... and 12 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
requested changes
Sep 20, 2023
Comment on lines
187
to
189
| || { | ||
| if chain_spec.is_cancun_activated_at_timestamp(self.timestamp) { | ||
| // default excess blob gas is zero |
There was a problem hiding this comment.
I think this can be simplified by checking the spec_id instead?
There was a problem hiding this comment.
oh right, I didn't think of that
mattsse
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the excess blob gas is missing, the EVM will otherwise return
ExcessBlobGasNotSetto the payload builder on the first cancun block, sincenext_block_blob_feereturnsNonefor pre-cancun blocks. This sets the excess blob gas to zero on the first cancun block.