Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(primitives): add blob_gas_used function in SealedBlock #4692

Merged
merged 3 commits into from
Sep 20, 2023
Merged

feat(primitives): add blob_gas_used function in SealedBlock #4692

merged 3 commits into from
Sep 20, 2023

Conversation

tcoratger
Copy link
Contributor

Should solve #4679.

@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #4692 (f807823) into main (6016da7) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/consensus/common/src/validation.rs 73.46% <100.00%> (-0.04%) ⬇️
crates/primitives/src/block.rs 78.15% <100.00%> (+0.11%) ⬆️

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.74% <0.00%> (-0.01%) ⬇️
unit-tests 63.36% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.17% <ø> (ø)
blockchain tree 83.75% <ø> (ø)
pipeline 88.54% <ø> (ø)
storage (db) 73.01% <ø> (ø)
trie 94.73% <ø> (-0.04%) ⬇️
txpool 49.44% <ø> (-0.49%) ⬇️
networking 77.10% <ø> (-0.07%) ⬇️
rpc 57.82% <ø> (ø)
consensus 63.24% <100.00%> (-0.01%) ⬇️
revm 28.16% <ø> (ø)
payload builder 8.45% <ø> (ø)
primitives 86.56% <100.00%> (-0.01%) ⬇️

mattsse
mattsse requested changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, smol nit

crates/primitives/src/block.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the C-enhancement New feature or request label Sep 20, 2023
tcoratger and others added 2 commits September 20, 2023 23:21
@tcoratger @mattsse
Update crates/primitives/src/block.rs
6f644d0 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@tcoratger
change function name to blob_gas_used
f807823
@mattsse mattsse added this pull request to the merge queue Sep 20, 2023
Merged via the queue into paradigmxyz:main with commit 1962014 Sep 20, 2023
22 checks passed
@tcoratger tcoratger changed the title feat(primitives): add calculate_blob_gas_used function in SealedBlock feat(primitives): add blob_gas_used function in SealedBlock Sep 20, 2023
@tcoratger tcoratger deleted the blob-gas branch September 20, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @mattsse