Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: shorten info interval #4666

Merged
merged 1 commit into from
Sep 20, 2023
Merged

chore: shorten info interval #4666

merged 1 commit into from
Sep 20, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 19, 2023

now that we're no longer logging each connection we can slightly decrease the info interval (-5s)

this also uses interval_start(3s) so the first info log arrives after 3s

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #4666 (93e6e45) into main (1406142) will decrease coverage by 17.79%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/node/events.rs 12.50% <0.00%> (-0.07%) ⬇️

... and 238 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.79% <0.00%> (-0.03%) ⬇️
unit-tests 45.18% <0.00%> (-18.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 19.79% <0.00%> (-12.39%) ⬇️
blockchain tree 42.52% <ø> (-41.08%) ⬇️
pipeline 63.26% <ø> (-25.28%) ⬇️
storage (db) 52.22% <ø> (-21.26%) ⬇️
trie 62.61% <ø> (-32.17%) ⬇️
txpool 39.28% <ø> (-10.65%) ⬇️
networking 60.92% <ø> (-16.31%) ⬇️
rpc 43.38% <ø> (-14.19%) ⬇️
consensus 51.05% <ø> (-11.61%) ⬇️
revm 22.14% <ø> (-5.91%) ⬇️
payload builder 8.45% <ø> (-0.12%) ⬇️
primitives 65.90% <ø> (-20.62%) ⬇️

@mattsse mattsse added this pull request to the merge queue Sep 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 19, 2023
@mattsse mattsse added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 0fbc3f6 Sep 20, 2023
22 checks passed
@mattsse mattsse deleted the matt/better-info-logs branch September 20, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants