-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(engine): always connect buffered blocks on r/w hook finish #4657
Conversation
Codecov Report
... and 23 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ab40d7b
to
b6a2d37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is logically correct, because when we start a hook with read-write access to the database, we can't process incoming payloads, and buffer them instead, hence we need to check the buffered blocks (payloads) for any such hook.
this is correct, however it looks like this breaks a few tests
@mattsse god bless engine tests, fixed |
This PR removes a separate
ConnectBufferedBlocks
engine hook action, and instead connects the buffered blocks upon completion of any hook with read-write access to the database.It is logically correct, because when we start a hook with read-write access to the database, we can't process incoming payloads, and buffer them instead, hence we need to check the buffered blocks (payloads) for any such hook.