Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm todo about polling jobs #4532

Merged
merged 1 commit into from
Sep 8, 2023
Merged

chore: rm todo about polling jobs #4532

merged 1 commit into from
Sep 8, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 8, 2023

closes #4403

See also #4496 (review)

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #4532 (fd843f6) into main (5f329e7) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/payload/builder/src/service.rs 34.64% <ø> (ø)

... and 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.73% <ø> (-0.02%) ⬇️
unit-tests 63.97% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.71% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.50% <ø> (ø)
networking 77.65% <ø> (+0.19%) ⬆️
rpc 57.43% <ø> (-0.02%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.51% <ø> (+0.02%) ⬆️

📢 Have feedback on the report? Share it here.

@mattsse mattsse merged commit d1f8c6e into main Sep 8, 2023
24 checks passed
@mattsse mattsse deleted the matt/rm-todo branch September 8, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve PayloadBuilderService polling service
1 participant