Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sale period to 21 days #4526

Merged
merged 1 commit into from
Sep 10, 2023
Merged

chore: bump sale period to 21 days #4526

merged 1 commit into from
Sep 10, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 8, 2023

14 is a bit too short imo, maybe even 21 is still too short

@mattsse mattsse added the A-meta Changes in the contributor workflow and planning label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #4526 (6fea7cb) into main (1ed5ae1) will increase coverage by 0.03%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.73% <ø> (-0.01%) ⬇️
unit-tests 63.94% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.71% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 75.32% <ø> (-0.01%) ⬇️
trie 94.88% <ø> (ø)
txpool 47.96% <ø> (+0.48%) ⬆️
networking 77.49% <ø> (+0.05%) ⬆️
rpc 57.43% <ø> (-0.02%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.42% <ø> (+<0.01%) ⬆️

📢 Have feedback on the report? Share it here.

@mattsse mattsse removed the request for review from gakonst September 8, 2023 11:50
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't mind the change

@mattsse mattsse added this pull request to the merge queue Sep 10, 2023
Merged via the queue into main with commit 2de63c6 Sep 10, 2023
24 checks passed
@mattsse mattsse deleted the matt/bump-stale-bot branch September 10, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Changes in the contributor workflow and planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants