Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage): recover senders if not found in database #4470

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Sep 4, 2023

Added a test for #4280 just to be sure it didn't break anything

@shekhirin shekhirin added A-db Related to the database C-test A change that impacts how or what we test labels Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #4470 (991d8ef) into main (03887a2) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
...tes/storage/provider/src/providers/database/mod.rs 44.37% <100.00%> (+4.25%) ⬆️
...torage/provider/src/providers/database/provider.rs 80.08% <100.00%> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.61% <0.00%> (-0.02%) ⬇️
unit-tests 63.81% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.71% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 74.98% <100.00%> (+0.05%) ⬆️
trie 94.88% <ø> (ø)
txpool 47.48% <ø> (-0.51%) ⬇️
networking 77.42% <ø> (-0.01%) ⬇️
rpc 57.37% <ø> (-0.01%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.37% <ø> (ø)
primitives 86.15% <ø> (+<0.01%) ⬆️

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shekhirin shekhirin added this pull request to the merge queue Sep 4, 2023
Merged via the queue into main with commit b32562f Sep 4, 2023
24 checks passed
@shekhirin shekhirin deleted the alexey/provider-sender-recover-test branch September 4, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants