Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix clippy #4468

Merged
merged 1 commit into from
Sep 4, 2023
Merged

chore: fix clippy #4468

merged 1 commit into from
Sep 4, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Sep 4, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited
Loading

Codecov Report

Merging #4468 (52945c8) into main (ed6a9b4) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/net/discv4/src/config.rs 54.69% <100.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.62% <100.00%> (ø)
unit-tests 63.78% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.71% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 74.88% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.48% <ø> (-0.51%) ⬇️
networking 77.41% <100.00%> (-0.10%) ⬇️
rpc 57.37% <ø> (-0.01%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.37% <ø> (ø)
primitives 86.14% <ø> (-0.01%) ⬇️

rakita
rakita reviewed Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shekhirin shekhirin added this pull request to the merge queue Sep 4, 2023
Merged via the queue into main with commit ee15bdb Sep 4, 2023
24 checks passed
@shekhirin shekhirin deleted the alexey/fix-clippy branch September 4, 2023 10:33
shekhirin added a commit that referenced this pull request Sep 4, 2023
@shekhirin
chore: fix clippy (#4468)
f01b2f0
shekhirin added a commit that referenced this pull request Sep 4, 2023
@shekhirin
chore: fix clippy (#4468)
8f79613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhirin @onbjerg @rakita