Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blob count checks #4447

Merged
merged 3 commits into from
Sep 1, 2023
Merged

feat: add blob count checks #4447

merged 3 commits into from
Sep 1, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 1, 2023

add missing checks for blob count

must not be 0 and not > max blobs per block

@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Sep 1, 2023
@mattsse mattsse force-pushed the matt/add-missing-blob-len-checks branch from 833c793 to 54fb0e6 Compare September 1, 2023 00:36
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few typo nits

crates/transaction-pool/src/error.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/error.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #4447 (53b44ed) into main (2a77138) will decrease coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/constants/eip4844.rs 85.45% <ø> (ø)
crates/rpc/rpc/src/eth/error.rs 9.60% <0.00%> (-0.17%) ⬇️
crates/transaction-pool/src/error.rs 0.00% <0.00%> (ø)
crates/transaction-pool/src/traits.rs 10.46% <0.00%> (-0.14%) ⬇️
crates/transaction-pool/src/validate/eth.rs 6.30% <0.00%> (-0.35%) ⬇️

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.65% <0.00%> (-0.02%) ⬇️
unit-tests 63.72% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.61% <ø> (ø)
blockchain tree 83.52% <ø> (ø)
pipeline 90.47% <ø> (ø)
storage (db) 74.81% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.59% <0.00%> (-0.74%) ⬇️
networking 77.40% <ø> (-0.10%) ⬇️
rpc 57.41% <0.00%> (-0.02%) ⬇️
consensus 63.34% <ø> (-0.09%) ⬇️
revm 31.74% <ø> (ø)
payload builder 6.37% <ø> (ø)
primitives 86.13% <ø> (-0.01%) ⬇️

mattsse and others added 2 commits August 31, 2023 17:45
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@mattsse mattsse added this pull request to the merge queue Sep 1, 2023
Merged via the queue into main with commit eb4126b Sep 1, 2023
24 checks passed
@mattsse mattsse deleted the matt/add-missing-blob-len-checks branch September 1, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants