Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: listen for all transactions #4436

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix: listen for all transactions #4436

merged 2 commits into from
Aug 31, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 31, 2023

No description provided.

@mattsse mattsse requested a review from gakonst as a code owner August 31, 2023 19:00
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #4436 (332368c) into main (b839e39) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.67% <ø> (-0.03%) ⬇️
unit-tests 63.78% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 29.61% <ø> (ø)
blockchain tree 83.52% <ø> (ø)
pipeline 90.47% <ø> (ø)
storage (db) 74.81% <ø> (ø)
trie 94.84% <ø> (-0.04%) ⬇️
txpool 48.11% <ø> (ø)
networking 77.46% <ø> (-0.09%) ⬇️
rpc 57.56% <ø> (-0.01%) ⬇️
consensus 63.42% <ø> (ø)
revm 31.74% <ø> (ø)
payload builder 6.37% <ø> (ø)
primitives 86.16% <ø> (-0.04%) ⬇️

@mattsse mattsse changed the title fix: allow propagate fix: listen for all transactions Aug 31, 2023
@mattsse mattsse requested a review from Rjected August 31, 2023 19:13
Rjected
Rjected approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattsse mattsse added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit d8a7ee2 Aug 31, 2023
24 checks passed
@mattsse mattsse deleted the matt/allow-propagate branch August 31, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected