Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(book): add documentation for ports #4370

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

tcoratger
Copy link
Contributor

Should solve #3550.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #4370 (730b091) into main (d8b1609) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.69% <ø> (+<0.01%) ⬆️
unit-tests 63.65% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.01% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.72% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.23% <ø> (ø)
networking 77.46% <ø> (-0.02%) ⬇️
rpc 57.99% <ø> (+0.02%) ⬆️
consensus 63.53% <ø> (+0.13%) ⬆️
revm 31.89% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.27% <ø> (-0.04%) ⬇️

@rkrasiuk rkrasiuk added C-docs An addition or correction to our documentation A-networking Related to networking in general A-rpc Related to the RPC implementation and removed A-networking Related to networking in general labels Aug 28, 2023
Comment on lines 133 to 145
### Peering Ports

- **Port:** 30303
- **Protocol:** TCP and UDP
- **Purpose:** Peering with other nodes for synchronization of blockchain data. Nodes communicate through this port to maintain network consensus and share updated information.
- **Exposure Recommendation:** This port should be exposed to enable seamless interaction and synchronization with other nodes in the network.

### Metrics Port

- **Port:** 9001
- **Protocol:** TCP
- **Purpose:** This port is designated for serving metrics related to the system's performance and operation. It allows internal monitoring and data collection for analysis.
- **Exposure Recommendation:** By default, this port should not be exposed to the public. It is intended for internal monitoring and analysis purposes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metrics and peering ports do not really belong to jsonrpc section, maybe we should add a Ports section under Run a Node? @mattsse @onbjerg thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkrasiuk I actually had a doubt because there were some ports that didn't belong here. But it makes sense to open a dedicated section in run a node. I just moved this documentation to a new section.

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good call on moving it to a new section

@onbjerg onbjerg added this pull request to the merge queue Aug 28, 2023
Merged via the queue into paradigmxyz:main with commit 7095733 Aug 28, 2023
23 checks passed
@tcoratger tcoratger mentioned this pull request Aug 29, 2023
@tcoratger tcoratger deleted the doc-port branch September 21, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants