Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validate-blob to extension trait #4355

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 24, 2023

adds EthPoolTransaction::validate_blob to extension trait and add new error variant that replaces Ok(false)

@mattsse mattsse requested a review from gakonst as a code owner August 24, 2023 20:49
@mattsse mattsse requested a review from Rjected August 24, 2023 20:49
@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #4355 (bf97010) into main (aad1895) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/lib.rs 100.00% <ø> (ø)
crates/primitives/src/transaction/eip4844.rs 36.87% <0.00%> (-0.38%) ⬇️
crates/primitives/src/transaction/mod.rs 77.51% <ø> (ø)
crates/transaction-pool/src/traits.rs 8.52% <0.00%> (-0.36%) ⬇️

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.70% <0.00%> (-0.02%) ⬇️
unit-tests 63.65% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.01% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.72% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.23% <0.00%> (-0.61%) ⬇️
networking 77.51% <ø> (-0.04%) ⬇️
rpc 57.97% <ø> (ø)
consensus 63.53% <ø> (ø)
revm 31.89% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.29% <0.00%> (-0.04%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, using the error over Ok(bool) is better & more descriptive

@Rjected Rjected added this pull request to the merge queue Aug 25, 2023
Merged via the queue into main with commit 50ba828 Aug 25, 2023
24 checks passed
@Rjected Rjected deleted the matt/add-validate-proof-fn branch August 25, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants