Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compare prev value against new value #4347

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 24, 2023

adds missing change check for storage diff

only record change if value actually changed

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Aug 24, 2023
@mattsse mattsse force-pushed the matt/check-changed-value branch 2 times, most recently from ab22d58 to e4028d4 Compare August 24, 2023 13:53
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #4347 (441ff07) into main (c2436a9) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)

... and 19 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.72% <0.00%> (-0.01%) ⬇️
unit-tests 63.66% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.03% <ø> (ø)
blockchain tree 81.82% <ø> (-0.75%) ⬇️
pipeline 90.07% <ø> (ø)
storage (db) 74.66% <ø> (-0.06%) ⬇️
trie 94.84% <ø> (-0.04%) ⬇️
txpool 47.94% <ø> (-0.53%) ⬇️
networking 77.52% <ø> (-0.02%) ⬇️
rpc 57.96% <ø> (-0.01%) ⬇️
consensus 63.09% <ø> (-0.44%) ⬇️
revm 31.89% <0.00%> (-0.09%) ⬇️
payload builder 6.78% <ø> (ø)
primitives 86.26% <ø> (-0.10%) ⬇️

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse enabled auto-merge August 24, 2023 14:15
@mattsse mattsse added this pull request to the merge queue Aug 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 24, 2023
@onbjerg onbjerg added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit fea753b Aug 24, 2023
24 checks passed
@onbjerg onbjerg deleted the matt/check-changed-value branch August 24, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants