Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make TransactionValidationTaskExecutor generic over V #4331

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 23, 2023

No description provided.

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Aug 23, 2023
@mattsse mattsse requested a review from Rjected August 23, 2023 15:43
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4331 (a7f2ed3) into main (5a7a57d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/validate/task.rs 0.00% <ø> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.80% <ø> (-0.02%) ⬇️
unit-tests 63.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.11% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.84% <ø> (-0.04%) ⬇️
txpool 47.29% <ø> (ø)
networking 77.48% <ø> (-0.01%) ⬇️
rpc 58.79% <ø> (-0.03%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.01% <ø> (ø)
payload builder 6.78% <ø> (ø)
primitives 86.08% <ø> (-0.01%) ⬇️

@mattsse mattsse added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit 96f58d7 Aug 23, 2023
24 checks passed
@mattsse mattsse deleted the matt/generic-task-validator branch August 23, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants