Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TransactionPool blob getters #4272

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 18, 2023

extend pool trait with getters for blobs

@mattsse mattsse added C-enhancement New feature or request M-changelog This change should be included in the changelog A-tx-pool Related to the transaction mempool labels Aug 18, 2023
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattsse mattsse enabled auto-merge August 18, 2023 18:35
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #4272 (e216902) into main (6077edf) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/lib.rs 39.20% <0.00%> (-2.12%) ⬇️
crates/transaction-pool/src/noop.rs 12.08% <0.00%> (-0.78%) ⬇️
crates/transaction-pool/src/pool/mod.rs 45.92% <0.00%> (-0.32%) ⬇️
crates/transaction-pool/src/traits.rs 8.19% <ø> (ø)

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.81% <0.00%> (-0.05%) ⬇️
unit-tests 63.77% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.13% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (ø)
trie 94.85% <ø> (ø)
txpool 49.20% <0.00%> (+0.29%) ⬆️
networking 77.45% <ø> (-0.24%) ⬇️
rpc 58.63% <ø> (-0.01%) ⬇️
consensus 63.53% <ø> (ø)
revm 32.03% <ø> (ø)
payload builder 6.82% <ø> (ø)
primitives 85.94% <ø> (-0.03%) ⬇️

@mattsse mattsse added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 82a42c9 Aug 18, 2023
24 checks passed
@mattsse mattsse deleted the matt/extend-txpoolwith-blob-getters branch August 18, 2023 18:52
PlamenHristov pushed a commit to PlamenHristov/reth that referenced this pull request Aug 19, 2023
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants