Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add recovered wrapper type and eth pool conversions #4267

Merged
merged 3 commits into from
Aug 18, 2023
Merged

feat: add recovered wrapper type and eth pool conversions #4267

merged 3 commits into from
Aug 18, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 18, 2023

adds a new PooledTransactionsElementEcRecovered type that has the recovered sender

adds conversion for EthPooledTransaction

this is currently missing the signature hash impl

mind adding this @Rjected

@mattsse mattsse requested a review from gakonst as a code owner August 18, 2023 13:51
@mattsse mattsse requested a review from Rjected August 18, 2023 13:51
@mattsse mattsse added C-enhancement New feature or request M-changelog This change should be included in the changelog A-tx-pool Related to the transaction mempool labels Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited
Loading

Codecov Report

Merging #4267 (9af77dd) into main (efab153) will decrease coverage by 0.03%.
Report is 6 commits behind head on main.
The diff coverage is 51.29%.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/lib.rs 100.00% <ø> (ø)
crates/primitives/src/transaction/pooled.rs 35.05% <0.00%> (-9.69%) ⬇️
crates/transaction-pool/src/traits.rs 8.19% <0.00%> (-0.90%) ⬇️
crates/primitives/src/transaction/mod.rs 78.27% <36.84%> (-1.78%) ⬇️
crates/primitives/src/transaction/eip1559.rs 83.94% <100.00%> (+1.97%) ⬆️
crates/primitives/src/transaction/eip2930.rs 92.59% <100.00%> (+0.92%) ⬆️
crates/primitives/src/transaction/eip4844.rs 39.36% <100.00%> (+3.40%) ⬆️
crates/primitives/src/transaction/legacy.rs 100.00% <100.00%> (ø)

... and 19 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.83% <28.57%> (-0.08%) ⬇️
unit-tests 63.75% <51.29%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.13% <ø> (ø)
blockchain tree 82.56% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.77% <ø> (+0.05%) ⬆️
trie 94.85% <ø> (+0.13%) ⬆️
txpool 48.85% <0.00%> (-0.21%) ⬇️
networking 77.45% <ø> (-0.07%) ⬇️
rpc 58.63% <ø> (ø)
consensus 63.53% <ø> (ø)
revm 32.03% <ø> (-0.12%) ⬇️
payload builder 6.82% <ø> (ø)
primitives 85.92% <59.39%> (-0.40%) ⬇️

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Aug 18, 2023
Rjected and others added 2 commits August 18, 2023 13:35
@Rjected
implement PooledTransactionsElement::signature_hash
329c9be 
 * refactors out the relevant encoding and payload length methods into
   the individual transaction types
 * implements Transaction::signature_hash with the methods on individual
   types
 * finally implements PooledTransactionsElement::signature_hash using
   these individual methods
@mattsse
fix docs link
9af77dd
Rjected
Rjected approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mattsse mattsse enabled auto-merge August 18, 2023 17:50
@mattsse mattsse added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 6077edf Aug 18, 2023
24 checks passed
@mattsse mattsse deleted the matt/add-pool-conversion branch August 18, 2023 18:06
PlamenHristov pushed a commit to PlamenHristov/reth that referenced this pull request Aug 19, 2023
@mattsse @Rjected @PlamenHristov
feat: add recovered wrapper type and eth pool conversions (paradigmxy…
253baed 
…z#4267)

Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
@mattsse @Rjected @alessandromazza98
feat: add recovered wrapper type and eth pool conversions (paradigmxy…
c8e973b 
…z#4267)

Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@Rjected Rjected mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request M-changelog This change should be included in the changelog S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @Rjected @onbjerg