feat: integrate blobstore in pool #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
M-changelog
Codecov Report
... and 29 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
onbjerg
reviewed
Aug 18, 2023
| #[derive(Metrics)] | ||
| #[metrics(scope = "transaction_pool")] | ||
| pub struct BlobStoreMetrics { | ||
| /// Number of failed inserts into the blobstore |
There was a problem hiding this comment.
Should we also have other metrics? Blob size, inserts, removes etc. (not only failures)
There was a problem hiding this comment.
will definitely add
but would like to include these prs asap
Rjected
approved these changes
Aug 18, 2023
crates/transaction-pool/src/lib.rs
Outdated
| //! | ||
| //! Blob transaction can be quite large hence they are stored in a separate blobstore. The pool is | ||
| //! responsible for inserting blob data for new transactions into the blobstore. | ||
| //! See als [ValidTransaction](validate::ValidTransaction) |
PlamenHristov
pushed a commit
to PlamenHristov/reth
that referenced
this pull request
Aug 19, 2023
alessandromazza98
pushed a commit
to alessandromazza98/reth
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another incremental change that adds the blobstore to the Pool type
needs a few followups, but best to keep these small