feat: implement network encoding for blob transactions #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
Codecov Report
... and 8 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
requested changes
Aug 13, 2023
| /// - `blobs` | ||
| /// - `commitments` | ||
| /// - `proofs` | ||
| pub fn encode_inner(&self, out: &mut dyn bytes::BufMut) { |
There was a problem hiding this comment.
yeah this needs to be pub because eth-wire needs to use it
There was a problem hiding this comment.
now is not pub any more because the types are in primitives
mattsse
reviewed
Aug 13, 2023
| pub proofs: Vec<Bytes48>, | ||
| } | ||
|
|
||
| impl BlobTransactionSidecar { |
|
some of the changes here seem like they'd be useful for #4170 |
This was referenced Aug 14, 2023
Rjected
force-pushed
the
dan/network-blob-tx
branch
from
0a61033
to
20d8138
Compare
mattsse
requested changes
Aug 16, 2023
Comment on lines
+196
to
+197
| // TODO: remove this! this will be different when we introduce the blobpool | ||
| let resp = PooledTransactions(transactions.into_iter().map(Into::into).collect()); |
There was a problem hiding this comment.
how it should work is that the pool should have a function that returns a Vec
so it would be useful to have that in primitives
Rjected
force-pushed
the
dan/network-blob-tx
branch
from
e9f228c
to
cd0bb61
Compare
mattsse
requested changes
Aug 16, 2023
| /// non-4844 signed transaction. | ||
| // TODO: redo arbitrary for this encoding - the previous encoding was incorrect | ||
| #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] | ||
| pub enum PooledTransactionsElement { |
Comment on lines
1330
to
1331
| /// A non-4844 signed transaction. | ||
| Transaction(TransactionSigned), |
There was a problem hiding this comment.
hmm, this now also has eip4844 as a variant, does it support decoding them without the sidecar?
This should be an invalid response, right?
should we flatten the variants?
| /// non-4844 signed transaction. | ||
| // TODO: redo arbitrary for this encoding - the previous encoding was incorrect | ||
| #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] | ||
| pub enum PooledTransactionsElement { |
There was a problem hiding this comment.
I'd like to move this to pooled.rs
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Rjected
force-pushed
the
dan/network-blob-tx
branch
from
9b256dc
to
e1ad9fb
Compare
mattsse
approved these changes
Aug 16, 2023
alessandromazza98
pushed a commit
to alessandromazza98/reth
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements network encoding and decoding methods for the
BlobTransactionmethod. The type is refactored to include aBlobSidecartype.TODO:
TransactionSignedinPooledTransaction