Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tx-pool): fix pending tx listener typo #4171

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

jacobkaufmann
Copy link
Contributor

fix apparent typo in new_pending_pool_transactions_listener doc comment

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honest work

@mattsse mattsse added the C-docs An addition or correction to our documentation label Aug 12, 2023
@mattsse mattsse enabled auto-merge August 12, 2023 19:14
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #4171 (458b058) into main (81e8ad4) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/traits.rs 9.09% <ø> (ø)

... and 14 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.91% <ø> (+0.05%) ⬆️
unit-tests 64.26% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.81% <ø> (+0.86%) ⬆️
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.71% <ø> (+0.04%) ⬆️
txpool 52.00% <ø> (+0.57%) ⬆️
networking 77.76% <ø> (+0.01%) ⬆️
rpc 58.67% <ø> (-0.02%) ⬇️
consensus 63.73% <ø> (ø)
revm 32.18% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.81% <ø> (-0.04%) ⬇️

@mattsse mattsse added this pull request to the merge queue Aug 12, 2023
Merged via the queue into paradigmxyz:main with commit 2a62f2d Aug 12, 2023
23 checks passed
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants