Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude single stop vm trace instruction #4149

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 10, 2023

special case where STOP should be excluded:

ref #4071

reth rn

{
    "jsonrpc": "2.0",
    "result": {
        "output": "0x",
        "stateDiff": null,
        "trace": [],
        "vmTrace": {
            "code": "0x",
            "ops": [
                {
                    "cost": 0,
                    "ex": {
                        "used": 0,
                        "push": [],
                        "mem": null,
                        "store": null
                    },
                    "pc": 0,
                    "op": "STOP"
                }
            ]
        }
    },
    "id": 1
}

erigon

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "output": "0x",
        "stateDiff": null,
        "trace": [],
        "vmTrace": {
            "code": "0x",
            "ops": []
        }
    }
}

with this fix:

{
    "jsonrpc": "2.0",
    "result": {
        "output": "0x",
        "stateDiff": null,
        "trace": [],
        "vmTrace": {
            "code": "0x",
            "ops": []
        }
    },
    "id": 1
}

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Aug 10, 2023
@mattsse mattsse requested a review from Rjected August 10, 2023 17:31
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #4149 (25faac1) into main (e43187b) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
...revm/revm-inspectors/src/tracing/builder/parity.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.86% <0.00%> (-0.01%) ⬇️
unit-tests 64.06% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.94% <ø> (ø)
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.71% <ø> (+0.04%) ⬆️
txpool 47.62% <ø> (-0.60%) ⬇️
networking 77.74% <ø> (+0.03%) ⬆️
rpc 58.68% <ø> (-0.01%) ⬇️
consensus 63.76% <ø> (ø)
revm 32.18% <0.00%> (-0.09%) ⬇️
payload builder 6.57% <ø> (ø)
primitives 87.91% <ø> (ø)

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense + the change is easy to understand

@Rjected Rjected added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 5c0ec6f Aug 10, 2023
24 checks passed
@Rjected Rjected deleted the matt/skip-last-stop branch August 10, 2023 18:11
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants