Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve ef-tests readability #4136

Merged
merged 1 commit into from
Aug 10, 2023
Merged

chore: improve ef-tests readability #4136

merged 1 commit into from
Aug 10, 2023

Conversation

DaniPopes
Copy link
Member

fn should_skip

@DaniPopes DaniPopes requested a review from gakonst as a code owner August 9, 2023 23:57
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #4136 (d32efa8) into main (4de1ff0) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

see 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.85% <ø> (-0.02%) ⬇️
unit-tests 64.09% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.94% <ø> (ø)
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 48.23% <ø> (+0.57%) ⬆️
networking 77.68% <ø> (-0.05%) ⬇️
rpc 58.70% <ø> (-0.01%) ⬇️
consensus 63.76% <ø> (ø)
revm 32.26% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.91% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Aug 10, 2023
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain C-test A change that impacts how or what we test labels Aug 10, 2023
Merged via the queue into paradigmxyz:main with commit 072c840 Aug 10, 2023
23 checks passed
@DaniPopes DaniPopes deleted the ef-tests branch August 10, 2023 15:13
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
@DaniPopes @alessandromazza98
chore: improve ef-tests readability (paradigmxyz#4136)
57ac31b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse