-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TransactionSigned::recover_signers
#4098
Conversation
Codecov Report
... and 44 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one nit
num_txes: usize, | ||
) -> Option<Vec<Address>> { | ||
// Arbitrary value. | ||
let threshold = 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be a const, we can add a note here the we expect a speedup > 10
Takes an iterator of
TransactionSigned
and usesrayon
to recover the signers if the list is bigger than 10.10 was kinda of an arbitrary value. I ran some tests locally using
random_signed_tx
and I got this on my machine: