chore: disable eta for headers & bodies #4065
Conversation
rkrasiuk
added
C-debt
There was a problem hiding this comment.
agree, but would like to reenable after improvements,
for example there are cases where bodies is at 100% for a bit
pending @shekhirin
Codecov Report
... and 84 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I'd leave the ETA for execution stage, as it's the longest one and ETA can actually give a rough estimate on how long it'd take to finish. Agree that for stages with more uneven commits it doesn't work good. |
|
i think ETA is fine for stages that don't use the network (hashing, execution~~, etc) |
good point, this actually outweighs the issues we have with it I think. suggest we keep it as is and push improvements instead? |
|
I still strongly agree with disabling it for headers/bodies stages 😄 |
rkrasiuk
force-pushed
the
rkrasiuk/disable-eta
branch
from
ecb4af8
to
5c215eb
Compare
| /// | ||
| /// NOTE: Currently ETA is disabled for Headers and Bodies stages until we find better | ||
| /// heuristics for calculation. | ||
| fn fmt_for_stage(&self, stage: StageId) -> String { |
There was a problem hiding this comment.
should we instead completely remove the eta field if it's known to be unknown (lol) all the time?
Motivation
Currently, ETA calculation is inconsistent and often ends up misleading the users.
Solution
Remove ETA from logs pending improvements.