Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use DepositContract on ChainSpec #4041

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Aug 3, 2023

Adds more details of the PoS deposit contract into chainspec.

@joshieDo joshieDo added C-enhancement New feature or request A-pruning Related to pruning or full node labels Aug 3, 2023
@joshieDo joshieDo requested a review from shekhirin August 3, 2023 10:41
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #4041 (02dfa84) into main (8c70524) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 86.20%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/args/pruning_args.rs 10.00% <0.00%> (-1.77%) ⬇️
crates/prune/src/pruner.rs 83.15% <ø> (ø)
bin/reth/src/init.rs 97.20% <100.00%> (ø)
crates/primitives/src/chain/spec.rs 96.47% <100.00%> (+0.04%) ⬆️
crates/primitives/src/hardfork.rs 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.48% <31.03%> (-0.01%) ⬇️
unit-tests 64.18% <86.20%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.85% <20.00%> (-0.03%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.40% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 47.36% <ø> (-0.63%) ⬇️
networking 77.43% <ø> (-0.02%) ⬇️
rpc 58.29% <ø> (+0.03%) ⬆️
consensus 63.86% <ø> (ø)
revm 32.71% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 88.00% <100.00%> (+<0.01%) ⬆️

Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is great. Next step would be filtering events based on the address + topic combination and pruning receipts even more.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
one nit

crates/primitives/src/chain/spec.rs Outdated Show resolved Hide resolved
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@joshieDo joshieDo enabled auto-merge August 3, 2023 11:58
@joshieDo joshieDo added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit 704c098 Aug 3, 2023
24 checks passed
@joshieDo joshieDo deleted the joshie/deposit-contract branch August 3, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pruning Related to pruning or full node C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants