feat(pruner): storage history #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto alexey/pruner-storage-history
shekhirin
force-pushed
the
alexey/pruner-storage-history
branch
from
2f5365c
to
ae9bb3a
Compare
shekhirin
force-pushed
the
alexey/pruner-account-history
branch
2 times, most recently
from
b9a7784
to
13131a4
Compare
shekhirin
force-pushed
the
alexey/pruner-storage-history
branch
from
ae9bb3a
to
2f5365c
Compare
…nto alexey/pruner-storage-history
…nto alexey/pruner-storage-history
…nto alexey/pruner-storage-history
…nto alexey/pruner-storage-history
…nto alexey/pruner-storage-history
…nto alexey/pruner-storage-history
…nto alexey/pruner-storage-history
shekhirin
force-pushed
the
alexey/pruner-storage-history
branch
from
ee60036
to
e5fe91b
Compare
…nto alexey/pruner-storage-history
Codecov Report
... and 8 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
approved these changes
Aug 2, 2023
Comment on lines
+511
to
+513
| // Shard contains block numbers that are higher than the target one, so we need to | ||
| // filter it. It is guaranteed that further shards for this address and storage slot | ||
| // will not contain the target block number, as it's in this shard. |
There was a problem hiding this comment.
this is a very useful comment
Comment on lines
+514
to
+517
| let blocks = blocks | ||
| .iter(0) | ||
| .skip_while(|block| *block <= to_block as usize) | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
these are only numbers and not the actual blocks, so we can safely load them
Comment on lines
+520
to
+525
| // shards are not allowed. | ||
| if key.sharded_key.highest_block_number == u64::MAX { | ||
| // If current shard is the last shard for this address and storage slot, | ||
| // replace it with the previous shard. | ||
| if let Some((prev_key, prev_value)) = cursor.prev()? { | ||
| if prev_key.address == key.address && |
There was a problem hiding this comment.
even if we have a bunch of levels, this is still readable imo
shekhirin
force-pushed
the
alexey/pruner-storage-history
branch
2 times, most recently
from
f5652d1
to
1317aea
Compare
joshieDo
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3694
Prunes:
StorageChangeSettable: all keys starting with block numbers (and their subkeys which are storage keys) which need to be prunedStorageHistorytable:highest_block_numberless than or equal to the target block number for pruning, delete the shard completely.highest_block_numbergreater than the target block number for pruning, filter block numbers inside the shard which are less than the target block number for pruning.