Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: serde rename revertReason #4002

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix: serde rename revertReason #4002

merged 1 commit into from
Jul 31, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 31, 2023

fixes wrong field name:

 "revert_reason": "TRANSFER_FROM_FAILED",

@mattsse mattsse requested a review from Rjected as a code owner July 31, 2023 14:51
@mattsse mattsse added M-changelog This change should be included in the changelog A-rpc Related to the RPC implementation labels Jul 31, 2023
@mattsse mattsse requested a review from onbjerg July 31, 2023 14:52
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #4002 (c8fb4c9) into main (c0544ed) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-types/src/eth/trace/geth/call.rs 100.00% <ø> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.26% <ø> (ø)
unit-tests 64.20% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.76% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.03% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.40% <ø> (-0.63%) ⬇️
networking 77.53% <ø> (+0.03%) ⬆️
rpc 58.53% <ø> (+0.02%) ⬆️
consensus 63.51% <ø> (ø)
revm 33.10% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 88.05% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit dee14c7 Jul 31, 2023
24 checks passed
@mattsse mattsse deleted the matt/fix-revert-reasn branch July 31, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected