Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add additional documentation to TxType #3996

Merged
merged 2 commits into from
Jul 31, 2023
Merged

docs: add additional documentation to TxType #3996

merged 2 commits into from
Jul 31, 2023

Conversation

joshieDo
Copy link
Collaborator

ref #3953 (comment)

So in the future we do not forget that adding a new type is a breaking change.

@joshieDo joshieDo requested a review from gakonst as a code owner July 31, 2023 10:07
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #3996 (b864a5e) into main (f41386d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/transaction/tx_type.rs 69.69% <ø> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.33% <ø> (-0.01%) ⬇️
unit-tests 64.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.67% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.00% <ø> (ø)
networking 77.64% <ø> (-0.02%) ⬇️
rpc 58.47% <ø> (ø)
consensus 63.51% <ø> (ø)
revm 33.08% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 87.91% <ø> (ø)

rkrasiuk
rkrasiuk approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, ty

@rkrasiuk rkrasiuk added C-docs An addition or correction to our documentation A-db Related to the database labels Jul 31, 2023
@mattsse mattsse enabled auto-merge July 31, 2023 11:27
@mattsse mattsse added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit ed3d736 Jul 31, 2023
24 checks passed
@mattsse mattsse deleted the docs/tx-type branch July 31, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-db Related to the database C-docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshieDo @mattsse @rkrasiuk