Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc-types): remove EngineRpcError #3975

Merged
merged 1 commit into from
Jul 28, 2023
Merged

chore(rpc-types): remove EngineRpcError #3975

merged 1 commit into from
Jul 28, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jul 27, 2023

Removes the EngineRpcError type, which was used briefly before the engine RPC API was simplified.

@Rjected Rjected added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation A-consensus Related to the consensus engine labels Jul 27, 2023
@Rjected Rjected requested a review from mattsse as a code owner July 27, 2023 21:56
@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Merging #3975 (fb52fb6) into main (369b9a7) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

see 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.38% <ø> (+<0.01%) ⬆️
unit-tests 64.42% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.16% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.18% <ø> (-0.56%) ⬇️
networking 77.64% <ø> (ø)
rpc 58.45% <ø> (+0.09%) ⬆️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.81% <ø> (-0.02%) ⬇️

mattsse
mattsse approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Jul 28, 2023
Merged via the queue into main with commit efd4895 Jul 28, 2023
24 checks passed
@mattsse mattsse deleted the dan/remove-engine-rpc-error-type branch July 28, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse