Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add eip4844 constants #3906

Merged
merged 1 commit into from
Jul 25, 2023
Merged

chore: add eip4844 constants #3906

merged 1 commit into from
Jul 25, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 25, 2023

add a few eip4844 constants that will be required

https://eips.ethereum.org/EIPS/eip-4844#parameters

@mattsse mattsse requested a review from gakonst as a code owner July 25, 2023 13:13
@mattsse mattsse added the C-enhancement New feature or request label Jul 25, 2023
@mattsse mattsse force-pushed the matt/add-eip4844-consts branch 2 times, most recently from 74f3343 to a2d3d1c Compare July 25, 2023 13:18
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #3906 (348c55b) into main (1b31a55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/constants/mod.rs 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.51% <ø> (-0.02%) ⬇️
unit-tests 64.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.24% <ø> (ø)
blockchain tree 83.01% <ø> (ø)
pipeline 89.66% <ø> (ø)
storage (db) 74.19% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.00% <ø> (ø)
networking 77.64% <ø> (-0.02%) ⬇️
rpc 58.28% <ø> (ø)
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 88.06% <ø> (+0.02%) ⬆️

Rjected
Rjected approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattsse mattsse added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit dc52650 Jul 25, 2023
24 checks passed
@mattsse mattsse deleted the matt/add-eip4844-consts branch July 25, 2023 13:58
@rkrasiuk rkrasiuk added the E-cancun Related to the Cancun network upgrade label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
C-enhancement New feature or request E-cancun Related to the Cancun network upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @Rjected @rkrasiuk