Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add execution aborted error #3901

Merged
merged 1 commit into from
Jul 25, 2023
Merged

chore: add execution aborted error #3901

merged 1 commit into from
Jul 25, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 25, 2023

ref #3900

add error variant for timed out calls

@mattsse mattsse requested a review from Rjected as a code owner July 25, 2023 10:53
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #3901 (721e456) into main (ea11787) will decrease coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc/src/eth/error.rs 10.05% <71.42%> (+2.65%) ⬆️

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.53% <0.00%> (-0.02%) ⬇️
unit-tests 64.41% <71.42%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.44% <ø> (ø)
blockchain tree 83.01% <ø> (ø)
pipeline 89.66% <ø> (ø)
storage (db) 74.19% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.00% <ø> (-0.60%) ⬇️
networking 77.63% <ø> (-0.02%) ⬇️
rpc 58.26% <71.42%> (-0.03%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 88.00% <ø> (+<0.01%) ⬆️

@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 25, 2023
Rjected
Rjected approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit f7e887f Jul 25, 2023
24 checks passed
@mattsse mattsse deleted the matt/add-timeout-error branch July 25, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected