-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add erigons debugTraceCallMany #3878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty,
A few suggestions, overall looks very good already
regarding the params, I think we need this structure, which differs from the currently used Vec<> I think
Thanks for the help. The new structs are for now placed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few changes and fixed the nonce issue which happened because we were using the wrong state: if we're replaying a block we need the parent block's state
Codecov Report
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hey, I barely understand rust, so my comment may be completly dumb, but I'll leave it anyway just to be sure:
|
@mattsse I would appreciate some feedback on those, before the new release! |
WIP #3522. I'm not sure about the function arguments, because if I understand correctly, the current implementation of trace_call_many doesn't use state_overrides and transaction_index.