-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pruner, storage): prune receipts & save checkpoints to database #3733
Conversation
4c0b0c5
to
bd644cd
Compare
72f0db0
to
6278abb
Compare
6278abb
to
7771c93
Compare
5ff7dc6
to
b46518b
Compare
Codecov Report
... and 12 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks very clean and was easy to follow.
tests also look great
storage_history | ||
/// Returns block up to which pruning needs to be done, inclusive, according to the provided | ||
/// prune mode and tip. | ||
pub fn prune_to_block(&self, mode: &PruneMode, tip: BlockNumber) -> BlockNumber { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe prune_target_block
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow-up PR will change the name
…aradigmxyz#3733) Co-authored-by: joshieDo <ranriver@protonmail.com>
Resolves #3697
Adds pruning of receipts the the Pruner which is activated during the live sync. Pruning of receipts is done in one go, and the progress is printed every 10k receipts. After pruning is done, writes checkpoints to the database.