Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(discv4): remove deprecated EF bootnodes #1680

Merged

Conversation

skylenet
Copy link
Contributor

@skylenet skylenet commented Mar 9, 2023

The bootnodes were removed in geth already: ethereum/go-ethereum#26828

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rkrasiuk
Copy link
Member

rkrasiuk commented Mar 9, 2023

@skylenet you also need to change static array length from 8 to 4 here

pub static MAINNET_BOOTNODES : [&str; 8] = [

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #1680 (32a3d24) into main (279ad34) will decrease coverage by 2.13%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
- Coverage   75.02%   72.90%   -2.13%     
==========================================
  Files         378      378              
  Lines       45463    45463              
==========================================
- Hits        34107    33143     -964     
- Misses      11356    12320     +964     
Flag Coverage Δ
integration-tests 17.44% <ø> (-4.11%) ⬇️
unit-tests 68.95% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/net/discv4/src/bootnodes.rs 0.00% <ø> (ø)
crates/rpc/rpc-api/src/eth.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/rpc/rpc-api/src/admin.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/rpc/rpc/src/eth/api/state.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/rpc/rpc/src/eth/api/block.rs 0.00% <0.00%> (-80.86%) ⬇️
...es/staged-sync/src/test_utils/clique_middleware.rs 0.00% <0.00%> (-79.17%) ⬇️
crates/rpc/rpc-types/src/eth/index.rs 0.00% <0.00%> (-75.00%) ⬇️
crates/rpc/rpc/src/admin.rs 0.00% <0.00%> (-72.73%) ⬇️
crates/staged-sync/src/test_utils/clique.rs 0.00% <0.00%> (-62.07%) ⬇️
crates/rpc/rpc/src/eth/api/mod.rs 21.83% <0.00%> (-60.92%) ⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rkrasiuk
Copy link
Member

rkrasiuk commented Mar 9, 2023

state test failure is unrelated

@rkrasiuk rkrasiuk merged commit e494011 into paradigmxyz:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants