feat(l2-withdrawals): Define OpEngineApi
#14414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
A-rpc
emhane
requested review from
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
mattsse
approved these changes
Feb 11, 2025
crates/optimism/rpc/Cargo.toml
Outdated
Comment on lines
72
to
73
| # required for windows target os | ||
| crunchy.workspace = true |
There was a problem hiding this comment.
this looks weird here, we didn't need this before,
there is an issue with crunchy 0.2.3 so maybe related to that, if accidentally bumped
imo we should be able to remove this here
| @@ -56,7 +60,7 @@ pub trait OpEngineApi<Engine: EngineTypes> { | |||
| #[method(name = "newPayloadV4")] | |||
| async fn new_payload_v4( | |||
| &self, | |||
| payload: ExecutionPayloadV3, | |||
| payload: OpExecutionPayloadV4, | |||
18aaddy
pushed a commit
to 18aaddy/reth
that referenced
this pull request
Feb 12, 2025
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14380
Towards: #13831