refactor: move ValidationApi setup to EthereumAddOns
#14342
Conversation
klkvr
requested review from
mattsse,
Rjected,
onbjerg and
gakonst
as code owners
| // only relevant for Ethereum and configured in `EthereumAddOns` | ||
| // implementation | ||
| // TODO: can we get rid of this here? | ||
| RethRpcModule::Flashbots => Default::default(), |
There was a problem hiding this comment.
don't like that we're doing this here now, I'm wondering if we should introduce generic for network-specific rpc namespaces?
There was a problem hiding this comment.
I'm wondering if we should introduce generic for
yeah, I been thinking about this a bit.
we'd need to integrate this into cli abstraction.
for now this is okay
I expect that the addons and this registry type will converge eventually, like offload more and more rpc setup to rpcaddons
for OP we also do this already:
reth/crates/optimism/node/src/node.rs
Line 222 in 4e49d77
so we'd need to find a way to approach this entire cli -> builder -> launch from the CLI perspective.
we kinda started experimenting with this a while ago with
but it's not used anywhere yet
reth/crates/cli/cli/src/lib.rs
Line 26 in 4e49d77
one approach could be to make NodeConfig entirely dependent on the RethCli, like the config is an output of the Cli which is then plugged into the builder
| #[derive(Debug)] | ||
| pub struct EthereumAddOns<N: FullNodeComponents> { | ||
| inner: RpcAddOns<N, EthApiFor<N>, EthereumEngineValidatorBuilder>, | ||
| } |
| @@ -859,6 +843,7 @@ impl RpcModuleConfigBuilder { | |||
|
|
|||
| /// A Helper type the holds instances of the configured modules. | |||
| #[derive(Debug, Clone)] | |||
| #[expect(dead_code)] // Consensus generic, might be useful in the future | |||
| // only relevant for Ethereum and configured in `EthereumAddOns` | ||
| // implementation | ||
| // TODO: can we get rid of this here? | ||
| RethRpcModule::Flashbots => Default::default(), |
There was a problem hiding this comment.
I'm wondering if we should introduce generic for
yeah, I been thinking about this a bit.
we'd need to integrate this into cli abstraction.
for now this is okay
I expect that the addons and this registry type will converge eventually, like offload more and more rpc setup to rpcaddons
for OP we also do this already:
reth/crates/optimism/node/src/node.rs
Line 222 in 4e49d77
so we'd need to find a way to approach this entire cli -> builder -> launch from the CLI perspective.
we kinda started experimenting with this a while ago with
but it's not used anywhere yet
reth/crates/cli/cli/src/lib.rs
Line 26 in 4e49d77
one approach could be to make NodeConfig entirely dependent on the RethCli, like the config is an output of the Cli which is then plugged into the builder
flashbots_ namespace is Ethereum specific and locked to concrete input types making it incompatible with custom Engine API we are about to introduce
This PR moves setup of
ValidationApito eth-specific add-ons allowing us to get rid ofpayload_validatorusage inRpcRegistry